Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stretch mode and expand mode fixes #1103

Merged
merged 15 commits into from
Sep 17, 2024
Merged

Stretch mode and expand mode fixes #1103

merged 15 commits into from
Sep 17, 2024

Conversation

Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented Sep 12, 2024 •
edited
Loading

(NOTE: i've moved the extra changes to separate prs, ythis pr now only contains stretch and expand fixes)

  • Fixed expand mode of export preview.
  • Changed occurrences of stretch_mode = 6 to stretch_mode = 5 (Reason: in Godot 3 the index for keep aspect centered was 6 but in Godot 4, it was moved to index 5)
    • Brush select buttons
    • Pattern select buttons
    • Tool brush preview button (BaseDraw and PaintSelect),
    • Bucket pattern button
    • ShowAnimate icon in ImageEffectParent.tscn at VBoxContainer/ShowAnimate
    • Start, Settings, OpenFolder icon at Recorder.tscn
  • Fixed incorrect resizing of backgroung transparent checker of effects ImageEffectParent.tscn, ResizeCanvas.tscn ShaderEffect.tscn
    • TransparentChecker is now a direct child of AspectRatioContainer, and stretch_mode for Preview is set to 5

@Variable-ind Variable-ind changed the title UI imps Stretch mode and expand mode fixes Sep 14, 2024
OverloadedOrama
OverloadedOrama approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OverloadedOrama OverloadedOrama merged commit b5ded76 into Orama-Interactive:master Sep 17, 2024
4 checks passed
@Variable-ind Variable-ind deleted the ui-imps branch September 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Variable-ind @OverloadedOrama